Skip to content

Update custom_route_loader.rst #9533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2018
Merged

Update custom_route_loader.rst #9533

merged 1 commit into from
May 5, 2018

Conversation

atailouloute
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz requested changes Apr 1, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

However, the file path should be different: config/routes.yaml

This is usually confusing because we have:

  • config/routes.yaml
  • config/routes/*
  • config/packages/routing.yaml
  • config/packages/*/routing.yaml
  • etc.

@xabbuh xabbuh added this to the 4.0 milestone Apr 20, 2018
@wouterj wouterj merged commit 7c46583 into symfony:4.0 May 5, 2018
wouterj added a commit that referenced this pull request May 5, 2018
@wouterj
bug #9533 Update custom_route_loader.rst (atailouloute)
a1b4f84 
This PR was merged into the 4.0 branch.

Discussion
----------

Update custom_route_loader.rst

Commits
-------

7c46583 Update custom_route_loader.rst
wouterj added a commit that referenced this pull request May 5, 2018
@wouterj
[#9533] Changed routing.yaml to routes.yaml for consistency with Flex
b3d0a68
@wouterj
Copy link
Member

wouterj commented May 5, 2018

Hi @atailouloute! Nice catch indeed, thanks for submitting a fix! I've merged your commit and aded a new one (b3d0a68) to change routing to routes, as proposed by Javier.

@atailouloute atailouloute deleted the patch-12 branch May 17, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz requested changes

Assignees

No one assigned

Labels

Routing Status: Needs Work

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@atailouloute @wouterj @javiereguiluz @xabbuh @carsonbot